Skip to content

Conversation

@LixiChronikouOriou
Copy link
Contributor

Zoura

On behalf of, and with power of attorney, herewith shall be filed plugins of Zoura aka AvianGeneticist, three in number for now.

@MCOfficer MCOfficer requested a review from Hecter94 October 21, 2025 20:03
Copy link
Member

@Hecter94 Hecter94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amphibious ships and Ringship both seem to be lacking a license file.
While the manifest claims they're licensed under CC-BY-SA-4.0, the plugin itself doesn't seem to include one.

Outfits Expanded does have a license file, but it's licensed under AGPL-3.0 whereas the manifest again says CC-BY-SA-4.0

@LixiChronikouOriou
Copy link
Contributor Author

It has been discussed with Zoura, so this is known. However, currently the work on TOA III has priority.

Hence I suggest to publish these works on the plugin site for now, and a future update will rectify the license issue.

Copy link
Member

@Hecter94 Hecter94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With licensing, it's assumed "All rights reserved" unless specified otherwise. Meaning in this case you can update the first two to be "All rights reserved" as that is technically what they are licensed as right now.

For Outfits Expanded, the license file and copyright file have two conflicting licenses, so that needs to be fixed before this can be merged.

name: Amphibious Ships
authors: Zoura
homepage: https://github.com/AvianGeneticist/Amphibious-Ships
license: CC-BY-SA-4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license: CC-BY-SA-4.0
license: ALL-RIGHTS-RESERVED

name: Ringship
authors: Zoura
homepage: https://github.com/AvianGeneticist/Ringship
license: CC-BY-SA-4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license: CC-BY-SA-4.0
license: ALL-RIGHTS-RESERVED

name: Zoura's Outfits Expanded
authors: Zoura
homepage: https://github.com/AvianGeneticist/Zoura-s-Outfits-Expanded
license: CC-BY-SA-4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, I cannot merge this since the plugin has two conflicting licenses and I don't know which is the "correct" one to put on the manifest. This plugin needs to fix its licensing and then the manifest updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding rectifying PRs were filed to Zoura's repos, waiting for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants